Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Stocktake in service layer #4351

Open
roxy-dao opened this issue Jul 2, 2024 · 0 comments
Open

Refactor Stocktake in service layer #4351

roxy-dao opened this issue Jul 2, 2024 · 0 comments

Comments

@roxy-dao
Copy link
Contributor

roxy-dao commented Jul 2, 2024

The suggestion

The stocktake insert/update files are getting really big and would be nice if some of the functions can be moved out into their own validate/generate files like in the rest of the repo.

Why should we invest time in this?

Nicer to read! And way easier to navigate through~

Are there any risks associated with this change?

Shouldn't be any risks?

How much effort is required?

Might take a few hours to move things out and make sure nothing has broken~

Agreed Solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants