Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"A trailing comma is not permitted after the rest element" Babel error #30

Open
sworupSussol opened this issue Oct 29, 2018 · 4 comments

Comments

@sworupSussol
Copy link

sworupSussol commented Oct 29, 2018

The newer version of Babel does not support trailing comma after code like

const {
    style,
    textStyle,
    width,
    onPress,
    text,
    isSelected,
    isAscending,
    ...containerProps,
  } = props;

Two files have this problem.
DataTable.js and HeaderCell.js

@Chris-Petty
Copy link
Contributor

Given you've made 2 PRs
Fixed in #28 + #29 .

@sworupSussol
Copy link
Author

Yes, I made the first PR in a hurry, did not realized there were more changes, so I closed it.

@Chris-Petty
Copy link
Contributor

Ah whoops, I thought they were merged not closed. This issue is still a good tweak.

@Chris-Petty Chris-Petty reopened this Oct 31, 2018
@sworupSussol
Copy link
Author

Reopened the PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants