Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "IDLE" interceptor ready state to "INACTIVE" #302

Closed
kettanaito opened this issue Nov 14, 2022 · 1 comment · Fixed by #303
Closed

Rename "IDLE" interceptor ready state to "INACTIVE" #302

kettanaito opened this issue Nov 14, 2022 · 1 comment · Fixed by #303

Comments

@kettanaito
Copy link
Member

kettanaito commented Nov 14, 2022 •
edited

  • Idle, I'm good and waiting for commands;
  • Inactive, I'm not good, I was not applied at all.

It's weird when the interceptor fails checkEnvironment and remains in IDLE state. It does not get applied, as expected, but the "IDLE" state is confusing when inspecting the interceptor. It must read "INACTIVE" both before it attempts to apply and if it shouldn't be applied due to the environment check.
@kettanaito kettanaito mentioned this issue Nov 14, 2022
Merged
@kettanaito
Copy link
Member Author

Released: v0.19.0 🎉

This has been released in v0.19.0!

Make sure to always update to the latest version (npm i @mswjs/interceptors@latest) to get the newest features and bug fixes.

Predictable release automation by @ossjs/release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: change "IDLE" ready state to "INACTIVE" mswjs/interceptors
1 participant
@kettanaito