Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Proxy-based ClientRequest interception #346

Closed
kettanaito opened this issue Feb 23, 2023 · 3 comments
Closed

Implement Proxy-based ClientRequest interception #346

kettanaito opened this issue Feb 23, 2023 · 3 comments
Assignees

Comments

@kettanaito
Copy link
Member

kettanaito commented Feb 23, 2023

The current implementation also causes race condition issues since we're running in parallel with the native end() (we're extending).

@kettanaito kettanaito self-assigned this Mar 1, 2023
@kettanaito
Copy link
Member Author

We already have primitives for a bit less verbose proxying with the createProxy() function. Should use that for this implementation as well.

@detj
Copy link

detj commented May 5, 2023

ow! I had assumed this was implemented using Proxy. Then I looked into the code and found only the XMLHttpRequestController implementation is based on Proxy.

Proxy for fetch would be fantastic!

@kettanaito
Copy link
Member Author

Largely irrelevant now. See #515.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants