Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending Socket interceptor tasks #575

Open
1 of 19 tasks
mikicho opened this issue Jun 1, 2024 · 2 comments
Open
1 of 19 tasks

Pending Socket interceptor tasks #575

mikicho opened this issue Jun 1, 2024 · 2 comments

Comments

@mikicho
Copy link
Contributor

mikicho commented Jun 1, 2024

Transfer Encoding:

support transfer-encoding: chunked

  • should pass filteringPath options
  • should pass filteringRequestBody options
  • match body with form multipart

preemtive timeout

It not relevant for fetch. We should consider if/how we want to support this for httpClient. Nice feature.

  • emits a timeout - with setTimeout
  • emits a timeout - with options.timeout
  • emits a timeout - with Agent.timeout
  • emits a timeout - options.timeout takes precedence over Agent.timeout
  • Emits the expected event sequence when aborted after a delay from the finish event

Headers

  • folds duplicate headers the same as Node
  • when keys are duplicated, is evaluated once per input field name, in correct order

Recorder

  • does not record requests from previous sessions
  • logs recorded objects
  • records and replays objects correctly
  • records and replays correctly with filteringRequestBody
  • records and replays gzipped nocks correctly
  • records and replays the response body
@kettanaito
Copy link
Member

Thanks for putting this down, @mikicho! Let's split these between ourselves and finish the interceptor. Please, if you are working on a task, put your GitHub handle next to it so I'd know, and I will do the same.

As usual, we can start with adding a test for the thing, verifying if it's not passing already, and then opening pull requests to #515. Does that sound good to you?

@kettanaito
Copy link
Member

kettanaito commented Jun 1, 2024

socket emits connect and secureConnect

This should already be the case:

Not sure if we have tests for this, may be indirectly tested and still missing test cases just for the connect and secureConnect events.

Edit: I'm assigning this to myself, will ensure those events are emitted correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants