Log stack trace for uncaught exceptions in request handlers

[jkieboom]

Scope

Improves an existing behavior

Compatibility

• This is a breaking change

Feature description

It is nice that msw automatically catches exceptions in request handlers and responds with a 500. I found it a little hard to debug as the debug logging only includes the error name and message but not the error stack.

msw/src/setupWorker/start/createRequestListener.ts

Lines 99 to 109 in 638fad9

	if (error instanceof Error) {
	devUtils.error(
	`Uncaught exception in the request handler for "%s %s":
	%s
	This exception has been gracefully handled as a 500 response, however, it's strongly recommended to resolve this error, as it indicates a mistake in your code. If you wish to mock an error response, please see this guide: https://mswjs.io/docs/recipes/mocking-error-responses`,
	request.method,
	request.url,
	error,
	)

It would be nice if this error logging also included the stack.

[kettanaito]

Hey, @jkieboom.

Have you inspected that 500 response in the network? It contains a JSON response body that includes a full stack of the caught error.

Do you wish for it to also be printed into the console?

[jkieboom]

Yes, the issue in my case is that my network requests go through a secondary library that transforms 500 responses into thrown errors but it doesn't know about special response payloads. So it would be helpful if it would also be printed.

[kettanaito]

I don't mind giving this a try. @jkieboom, would you have a chance to open a pull request?

[jkieboom]

#1417

[kettanaito]

Awesome! Thank you for working on this. I've left a few thoughts on the change, would like to know your opinion on those.