fix: resolve the "eventTargets" error in JSDOM by dropping "instanceof" #1813
Conversation
|
@mattcosta7
Happens when TypeError message is thrown within the following environment: jest 27 Found this on jsdom changelog, even though it is for version 18 of jsdom, but here (in my environemnt) it seems to be the same case. |
in some environments, particularly jsdom with jest, Error objects may not be `instanceof Error` despite being similar and used in the same way. To avoid these issues we only need to validate the shape and properties that might be thrown. In some cases these could false positive, however it's less likely that they'll false positive, than it is that jest/jsdom will throw these objects _like_ the errors they represent (guaranteed)
| * instances of `Error` or its subclasses, despite being similar | ||
| * to them. | ||
| */ | ||
| export function isNodeExceptionLike( |
There was a problem hiding this comment.
renamed this function and added some docs that it's very similar to a NodeException but isn't guaranteed to be and instanceof it
mattcosta7
changed the title
instanceof in isNodeException check. Rename that function
|
Thanks for fixing this, @mattcosta7. Yet another day, yet another JSDOM shenanigans. I will give this a look and let's have this merged. |
kettanaito
changed the title
instanceof in isNodeException check. Rename that function
|
Thanks @mattcosta7 @kettanaito !! |
Released: v2.0.2 🎉This has been released in v2.0.2! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
fixes #1785
fixes #1803 (I think)
Avoid using instanceof to deal with jest/jsdom potentially overriding the global error
I haven't had a chance to try and validate this assumption, but I am assuming that this check is failing on the
instanceof Errorand therefore rethrowing instead of being caught.In the past I've seen this with jest overriding globals such that these instanceof checks don't always do what's expected
I validated this locally by pulling
mswjs/examplesand modifying the installed version in thewith-jestnode_modules. Once this was done the tests in that repo pass correctly withmsw@2+whereas without this change they fail