New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: null-body responses enforced in createResponseListener instead o… #1895

Merged

mattcosta7 merged 13 commits into main from fix-null-body-responses

Dec 1, 2023

Contributor

mattcosta7 commented Nov 28, 2023 •

edited

closes #1894
fixes #1893

This should fix passthrough errors specifically, where the body was a stream and the status code cannot support a body.


          fix: null-body responses enforced in createResponseListener instead o…

687d374

…f worker

mattcosta7 commented

View reviewed changes

src/mockServiceWorker.js Show resolved Hide resolved


          test: update case to check pageerrors

cd9be70

mattcosta7 commented

View reviewed changes

src/browser/setupWorker/start/createResponseListener.ts Outdated Show resolved Hide resolved

mattcosta7 added 4 commits

November 28, 2023 11:37


          test: add passthrough cases

6e82767


          test: node test case

b057f3c


          test: single for of block

4ba5b4c


          test: simplify server handlers

e473d68

mattcosta7 requested a review from kettanaito

November 28, 2023 16:56

mattcosta7 marked this pull request as ready for review

November 28, 2023 16:56

mattcosta7 mentioned this pull request

fix: force response bodies for 304s to be null #1894

Closed

kettanaito reviewed

View reviewed changes

test/browser/msw-api/regression/null-body.test.ts Outdated Show resolved Hide resolved


          test: remove copy/paste sleep

0d23cd1

kettanaito reviewed

View reviewed changes

test/node/msw-api/req/passthrough.node.test.ts Outdated Show resolved Hide resolved

kettanaito reviewed

View reviewed changes

test/node/msw-api/req/passthrough.node.test.ts Outdated Show resolved Hide resolved

kettanaito reviewed

View reviewed changes

test/node/msw-api/req/passthrough.node.test.ts Outdated Show resolved Hide resolved

Member

kettanaito commented Nov 28, 2023

Does this change negate #1894? If so, we can mark it as "Closes #1894".

kettanaito reviewed

View reviewed changes

src/browser/setupWorker/start/createResponseListener.ts Show resolved Hide resolved

kettanaito reviewed

View reviewed changes

src/browser/setupWorker/start/createResponseListener.ts Outdated Show resolved Hide resolved

mattcosta7 added 5 commits

November 28, 2023 12:32


          test: remove it.each

91734ea


          test: use params for null body test codes

0a9b68f


          test: inline status parse

1d7ab5b


          chore: inline response create

8509fe9


          chore: newline

5f4a039

mattcosta7 requested a review from kettanaito

November 28, 2023 17:45

mattcosta7 self-assigned this


          Merge branch 'main' into fix-null-body-responses

1527e1f

kettanaito approved these changes

View reviewed changes

Member

kettanaito left a comment

🚀

kettanaito added the release candidate label

mattcosta7 merged commit ed09722 into main

10 checks passed

mattcosta7 deleted the fix-null-body-responses branch

December 1, 2023 13:08

Member

kettanaito commented Dec 4, 2023

Released: v2.0.10 🎉

This has been released in v2.0.10!

📄 Release notes
📦 npm package

Make sure to always update to the latest version (npm i msw@latest) to get the newest features and bug fixes.

Predictable release automation by @ossjs/release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment