fix: annotate the "requestId" response resolver argument #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
changed the title
kettanaito
changed the title
kettanaito
reviewed
Jan 15, 2024
| @@ -736,7 +736,8 @@ describe('run', () => { | |||
| userId: 'abc-123', | |||
| }, | |||
| }) | |||
| const result = await handler.run({ request }) | |||
| const requestId = 'requestId' | |||
There was a problem hiding this comment.
Let's use either the uuid4() we already have or crypto.randomUUID() here. It's a little touch but the more your tests resemble the way your system works, the better.
skvale
changed the title
kettanaito
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Fantastic! Thank you for yet another contribution, @skvale 👏
I've added the type tests for the requestId argument of the response resolver so we could've caught this issue sooner (no tests failed === tests were missing).
kettanaito
changed the title
Released: v2.1.1 🎉This has been released in v2.1.1! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After trying out #1942 I found the types weren't working as expected even though
requestIdwas passing throughBefore
After