Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"start"/"stop" methods should return a Promise #58

Closed
kettanaito opened this issue Mar 8, 2020 · 1 comment · Fixed by #64
Closed

"start"/"stop" methods should return a Promise #58

kettanaito opened this issue Mar 8, 2020 · 1 comment · Fixed by #64
Assignees
@kettanaito

Comments

@kettanaito
Copy link
Member

Current behavior

Methods return nothing, impossible to listen to the registration or removal of registration of the Service Worker.

Such behavior also makes these methods un-testable, as they provide no native method to react to them.

Expected behavior

I should be able to do start().then and stop().then to react to the respective Service Worker events (registration/unregistration).
@kettanaito kettanaito mentioned this issue Mar 8, 2020
Merged
8 tasks
@kettanaito kettanaito self-assigned this Mar 13, 2020
@kettanaito kettanaito mentioned this issue Mar 13, 2020
Merged
@kettanaito
Copy link
Member Author

Released in 0.8.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kettanaito kettanaito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Returns Promise from "start" and "stop" calls mswjs/msw
1 participant
@kettanaito