Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat integrity check failure as a warning #87

Closed
kettanaito opened this issue Mar 28, 2020 · 0 comments · Fixed by #88
Closed

Treat integrity check failure as a warning #87

kettanaito opened this issue Mar 28, 2020 · 0 comments · Fixed by #88
Assignees

Comments

@kettanaito
Copy link
Member

kettanaito commented Mar 28, 2020

Originating from #81, I think that treating integrity check failure as an error and disabling the mocking is a safe, but too extreme measure for the users.

Expected behavior

  • Integrity check failure is still treated as an error, for the purpose of giving it a higher priority when the user browses's his console output.
  • Integrity check failure does not disable the mocking, for the purpose of changes that do not necessarily break backwards-compatibility. It's up to user to update the Service Worker, although it's highly recommended.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant