Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt "matchPath" from "react-router"? #9

Closed
kettanaito opened this issue Dec 25, 2018 · 1 comment
Closed

Adopt "matchPath" from "react-router"? #9

kettanaito opened this issue Dec 25, 2018 · 1 comment

Comments

@kettanaito
Copy link
Member

kettanaito commented Dec 25, 2018 •
edited

I suggest to consider adopting matchPath utility from react-router.

Why:

It's a tested function from one of the most used routing solution. It will most likely handle all the necessary routing scenarios, which are crucial for API mocking as well.

Cons:

  • Much heavier than a single matching function
  • Creates an extra dependency
@kettanaito kettanaito mentioned this issue Jan 1, 2019
Merged
@kettanaito
Copy link
Member Author

Merged under #14. Will be released in the next patch release 0.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kettanaito