PyFisher lensInterface Issue(s)

[dwhan89]

We noticed that there were discrepancies between polarization estimator noise curves from pyfisher/lensInterface.lensNoise() and orphics.lensing.lensing_noise() functions.

Here the dashed lines are from lensInterface.lensNoise and the solid lines are from lensing.lensing_noise(). I am opening this issue to track the changes needed to be made to lensInterface.py

1. L min for Kappa is hard-coded (https://github.com/msyriac/pyfisher/blob/master/pyfisher/lensInterface.py#L51)

2. L max for Kappa set in param.ini is not being used (https://github.com/msyriac/pyfisher/blob/master/pyfisher/lensInterface.py#L55)

3. Wrong function signature for getNlIterative (https://github.com/msyriac/pyfisher/blob/master/pyfisher/lensInterface.py#L68)

• call from lensInterface.py
  myNls.getNlIterative(pols,kellmin,kellmax,tellmax,pellmin,pellmax,dell=dell,halo=True,plot=plot)

• function definition in orphics/lensing.py
  def getNlIterative(self,polCombs,pellmin,pellmax,dell=20,halo=True,dTolPercentage=1.,verbose=True,plot=False,max_iterations=np.inf,eff_at=60,kappa_min=0,kappa_max=np.inf):

4. Polarization l min and l max are not used in getNlIterative (It is probably better to open an issue about this on orphics repo).
   (https://github.com/msyriac/orphics/blob/master/orphics/lensing.py#L1218)