You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We noticed that there were discrepancies between polarization estimator noise curves from pyfisher/lensInterface.lensNoise() and orphics.lensing.lensing_noise() functions.
Here the dashed lines are from lensInterface.lensNoise and the solid lines are from lensing.lensing_noise(). I am opening this issue to track the changes needed to be made to lensInterface.py
call from lensInterface.py myNls.getNlIterative(pols,kellmin,kellmax,tellmax,pellmin,pellmax,dell=dell,halo=True,plot=plot)
function definition in orphics/lensing.py def getNlIterative(self,polCombs,pellmin,pellmax,dell=20,halo=True,dTolPercentage=1.,verbose=True,plot=False,max_iterations=np.inf,eff_at=60,kappa_min=0,kappa_max=np.inf):
We noticed that there were discrepancies between polarization estimator noise curves from pyfisher/lensInterface.lensNoise() and orphics.lensing.lensing_noise() functions.
Here the dashed lines are from lensInterface.lensNoise and the solid lines are from lensing.lensing_noise(). I am opening this issue to track the changes needed to be made to lensInterface.py
L min for Kappa is hard-coded (https://github.com/msyriac/pyfisher/blob/master/pyfisher/lensInterface.py#L51)
L max for Kappa set in param.ini is not being used (https://github.com/msyriac/pyfisher/blob/master/pyfisher/lensInterface.py#L55)
Wrong function signature for getNlIterative (https://github.com/msyriac/pyfisher/blob/master/pyfisher/lensInterface.py#L68)
call from lensInterface.py
myNls.getNlIterative(pols,kellmin,kellmax,tellmax,pellmin,pellmax,dell=dell,halo=True,plot=plot)
function definition in orphics/lensing.py
def getNlIterative(self,polCombs,pellmin,pellmax,dell=20,halo=True,dTolPercentage=1.,verbose=True,plot=False,max_iterations=np.inf,eff_at=60,kappa_min=0,kappa_max=np.inf):
(https://github.com/msyriac/orphics/blob/master/orphics/lensing.py#L1218)
The text was updated successfully, but these errors were encountered: