"dirty" in uname for msys2-runtime v3.4.3 ??

[goyalyashpal]

• why does the uname -a shows "dirty" in "3.4.3-dirty.x86_64 2022-12-19 20:20 UTC" for recent version of msys2-runtime-3.4.3-4 ??

• and where's the changelog for that?

  • i searched at the upstream URL: https://www.cygwin.com/ but couldn't find it
  • i also ran the following command but returned empty handed for all the packages i tried it for: nano, mintty, less, info, make, python

$ pacman -Qc msys2-runtime
error: no changelog available for 'msys2-runtime'.

Originally posted by @yashpalgoyal1304 in #3012 (comment)

[MehdiChinoune]

• why does the uname -a shows "3.4.3-dirty.x86_64 2022-12-19 20:20 UTC" for recent version of msys2-runtime-3.4.3-4 ??

dirty is git term to describe a repo status having uncommitted changes https://mirrors.edge.kernel.org/pub/software/scm/git/docs/gitglossary.html#def_dirty.

• and where's the changelog for that?

  • i searched at the upstream URL: https://www.cygwin.com/ but couldn't find it
  • i also ran the following command but returned empty handed for all the packages i tried it for: nano, mintty, less, info, make, python

$ pacman -Qc msys2-runtime
error: no changelog available for 'msys2-runtime'.

We don't provide changelog files with our packages, for msys2-runtime/cygwin see:

• https://github.com/msys2/msys2-runtime/blob/msys2-3.4.3/winsup/cygwin/release/3.4.3
• https://github.com/cygwin/cygwin/blob/master/winsup/cygwin/release/3.4.3
• https://www.cygwin.com/cygwin-ug-net/ov-new.html

[goyalyashpal]

We don't provide changelog files with our packages,

hey, can a note be provided for that? as i think that msys2 already uses a patched pacman. so:

$ pacman -Qc <any>
sorry: we don't provide changelog files with our packages

[MehdiChinoune]

We don't provide changelog files with our packages,

hey, can a note be provided for that? as i think that msys2 already uses a patched pacman. so:

$ pacman -Qc <any>
sorry: we don't provide changelog files with our packages

It is not a general rule, It's up to the packager to include the changelog but It is not mandatory, so majority don't bother searching and including changelog.

[goyalyashpal]

oh ohkay.

[jeremyd2019]

I think it may make sense now to set the version stuff in the PKGBUILD so that the 'official' packaged version doesn't report as 'dirty', and possibly even include the pkgrel in the uname version.

Otherwise, the packaged version will always be "dirty" because it is checked out from the upstream cygwin tag and then has patches generated from this repo applied to that checkout, so it will always be "dirty".

I am kind of second-guessing transferring this to msys2-runtime now, because I think the proper place to set this is in the MSYS2-packages/msys2-runtime/PKGBUILD, probably by using the same mechanism as cygport does for upstream packaging of the cygwin dll.

[jeremyd2019]

Should be fixed in #3485 (yep, shouldn't have transferred it)

[goyalyashpal]

yep, shouldn't have transferred it

😆 yeah, it's sometimes a bit confusing which repo an issue belongs to. glad to have been replicated 🤣