Git-SVN: GIT_ASKPASS is buggy

[dkp85]

When you use GIT_ASKPASS to enter passwords, it never works because function _read_password from Prompt.pm is buggy. Indeed, this line is supposed to remove \r\n:

$password =~ s/[\012\015]//; # \n\r

But a 'g' is missing so \r\n is never removed. The correct line is

$password =~ s/[\012\015]//g; # \n\r

The issue can be reproduced using git-gui--askpass.

[csware]

See: http://thread.gmane.org/gmane.comp.version-control.git/185600, http://thread.gmane.org/gmane.comp.version-control.git/207161 and http://code.google.com/p/tortoisegit/issues/detail?id=318.
However, for one year now nothing happened.

[csware]

My patch is going to be applied in git 1.8.2.

[sschuberth]

@csware In fact your ss/svn-prompt was already merged for the just released Git 1.8.1.1 maintenance release, see http://thread.gmane.org/gmane.comp.version-control.git/213522.

[sschuberth]

@patthoyts recently merged upstream Git 1.8.1.1 into our master branch, so the next Git for Windows release will include @csware's fix.