Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: support custom GitHub URLs #1

Closed
ccnokes opened this issue Mar 18, 2019 · 3 comments 路 Fixed by #2
Closed

Feature request: support custom GitHub URLs #1

ccnokes opened this issue Mar 18, 2019 · 3 comments 路 Fixed by #2

Comments

@ccnokes
Copy link

ccnokes commented Mar 18, 2019

I'd like to use this against my company's internal enterprise github instance, but it looks like api.github.com is hardcoded in. It'd be great if I could pass a github URL in as an env param. This is a really useful package btw, thanks 馃憤

@mszostok
Copy link
Owner

Hi @ccnokes, thanks for reporting the issue!

I totally agree with your feature request, so I will add it at the end of the day:)

Cheers,
Mateusz

@mszostok
Copy link
Owner

mszostok commented Mar 21, 2019

Hi @ccnokes,

Describe functionality was implemented. Right now u can pass your own GitHub URL by setting GITHUB_BASE_URL.

I tested that with our private enterprise GitHub. Basically you need to execute such command:

env REPOSITORY_PATH="abc/commercialization" GITHUB_BASE_URL="https://github.abc.corp/api/v3" VALID_OWNER_CHECKER_ORGANIZATION_NAME="org" ./codeowners-validator

I also created the first release with binaries that you can download:
https://github.com/mszostok/codeowners-validator/releases

so having Go on your host is no longer required.

If the repo license is not acceptable for you then we can discuss that :)

@ccnokes
Copy link
Author

ccnokes commented Mar 21, 2019

馃帀 Thank you so much! I really appreciate the binaries too -- now this is easy to integrate into our build or a git hook 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants