Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm -rf default - electric boogaloo #3

Merged
merged 2 commits into from Jan 27, 2022
Merged

rm -rf default - electric boogaloo #3

merged 2 commits into from Jan 27, 2022

Conversation

wsor4035
Copy link
Contributor

this pr does the following

  • removed the basically pointless default dep
  • refactors the code
  • refactors .luacheckrc file

@wsor4035 wsor4035 changed the title rm -rf default electric boogaloo rm -rf default - electric boogaloo Jan 26, 2022
@BuckarooBanzay
Copy link
Member

nice work 👍

S-S-X
S-S-X reviewed Jan 26, 2022
View reviewed changes
.luacheckrc Show resolved Hide resolved
@OgelGames
Copy link
Contributor

I still disagree with the sounds_api submodule, but the other changes are good.

@S-S-X
Copy link
Member

S-S-X commented Jan 26, 2022

I still disagree with the sounds_api submodule, but the other changes are good.

Similar opinions here and already submitted review comment for possible luacheck config change / question.

I could also add exact reason why I could disagree with sounds_api submodule: AFAIK it causes duplicate code under the hood (not considering just actual duplicate files on disk but duplicate code in memory) while mod dependency wont.
Code size however is not really significant as long as submodules are used wisely but it opens route for hard to detect mistakes.

@wsor4035 wsor4035 merged commit 924bd84 into master Jan 27, 2022
@SwissalpS SwissalpS mentioned this pull request Jan 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OgelGames OgelGames OgelGames left review comments

@S-S-X S-S-X S-S-X left review comments

@BuckarooBanzay BuckarooBanzay BuckarooBanzay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wsor4035 @BuckarooBanzay @OgelGames @S-S-X