Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add I3 support + update to formspecs v2 #22

Merged
merged 14 commits into from Apr 16, 2022
Merged

add I3 support + update to formspecs v2 #22

merged 14 commits into from Apr 16, 2022

Conversation

wsor4035
Copy link
Contributor

what the title says

@wsor4035 wsor4035 added the enhancement New feature or request label Apr 13, 2022
@wsor4035 wsor4035 self-assigned this Apr 13, 2022
@wsor4035 wsor4035 marked this pull request as ready for review April 15, 2022 18:59
@fluxionary
Copy link
Member

Fixing luacheck by making it assume the expected fields are present, is acceptable to me

@fluxionary
Copy link
Member

Should you also add i3 stylization to the filter injector formspecs?

@wsor4035
Copy link
Contributor Author

wsor4035 commented Apr 16, 2022 •
edited

Should you also add i3 stylization to the filter injector formspecs?

🤦‍♂️ missed them, thanks for pointing them out, added 7dfa021

@fluxionary
Copy link
Member

Should you also add i3 stylization to the filter injector formspecs?

man_facepalming missed them, thanks for pointing them out, added 7dfa021

screenshot_20220416_112555

misplaced button in the stackwise injector

@wsor4035
Copy link
Contributor Author

wsor4035 commented Apr 16, 2022 •
edited

Edit: seems i cant hide/delete my own comment? anyways, ignore this

@wsor4035
Copy link
Contributor Author

Should you also add i3 stylization to the filter injector formspecs?

man_facepalming missed them, thanks for pointing them out, added 7dfa021

screenshot_20220416_112555

misplaced button in the stackwise injector

fixed 7426e11

@wsor4035 wsor4035 merged commit 37eef73 into master Apr 16, 2022
@fluxionary
Copy link
Member

how it looks on YL:

screenshot_20220416_115043

how it looks now, after the last commit (37eef73)

screenshot_20220416_115059

fluxionary
fluxionary reviewed Apr 16, 2022
View reviewed changes
teleport_tube.lua Outdated Show resolved Hide resolved
@OgelGames OgelGames deleted the i3 branch January 14, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluxionary fluxionary fluxionary left review comments

@BuckarooBanzay BuckarooBanzay BuckarooBanzay approved these changes

@luk3yx luk3yx Awaiting requested review from luk3yx

Assignees

@wsor4035 wsor4035

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wsor4035 @fluxionary @BuckarooBanzay