Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'mesecons' from optional dependencies to dependencies #44

Closed
GrimPixel opened this issue Sep 19, 2022 · 4 comments
Closed

Change 'mesecons' from optional dependencies to dependencies #44

GrimPixel opened this issue Sep 19, 2022 · 4 comments
Labels
bug Something isn't working question Further information is requested

Comments

@GrimPixel
Copy link

If I don't enable mesecons, it will say

ModError: Failed to load and run script from /home/user/.minetest/mods/pipeworks/init.lua:
/home/user/.minetest/mods/pipeworks/lua_tube.lua:302: attempt to index global 'mesecon' (a nil value)
stack traceback:
/home/user/.minetest/mods/pipeworks/lua_tube.lua:302: in main chunk
[C]: in function 'dofile'
/home/user/.minetest/mods/pipeworks/init.lua:147: in main chunk
Check debug.txt for details.

@BuckarooBanzay BuckarooBanzay added bug Something isn't working question Further information is requested labels Sep 19, 2022
@BuckarooBanzay
Copy link
Member

Can you check your setup: this should not happen unless you have the digilines mod enabled (which should not work without mesecons iirc)

pipeworks/init.lua

Lines 181 to 184 in e45eca7

if pipeworks.enable_lua_tube and
(minetest.get_modpath("mesecons") or minetest.get_modpath("digilines")) then
dofile(pipeworks.modpath.."/lua_tube.lua")
end

Your mod(s) might be out of date

@S-S-X
Copy link
Member

S-S-X commented Sep 19, 2022

I think lua tube requires both so we could make it explicit to not depend on external dependency

- 		(minetest.get_modpath("mesecons") or minetest.get_modpath("digilines")) then
+ 		minetest.get_modpath("mesecons") and minetest.get_modpath("digilines") then

or if digilines is actually optional for lua tube (mesecons isn't, probably same with digilines but not 100% sure):

- if pipeworks.enable_lua_tube and 
- 		(minetest.get_modpath("mesecons") or minetest.get_modpath("digilines")) then 
+ if pipeworks.enable_lua_tube and minetest.get_modpath("mesecons") then

@wsor4035
Copy link
Contributor

Can you check your setup: this should not happen unless you have the digilines mod enabled (which should not work without mesecons iirc)

pipeworks/init.lua

Lines 181 to 184 in e45eca7

if pipeworks.enable_lua_tube and
(minetest.get_modpath("mesecons") or minetest.get_modpath("digilines")) then
dofile(pipeworks.modpath.."/lua_tube.lua")
end

Your mod(s) might be out of date

it does "work" without mesecons or at least it boots without crashing https://github.com/minetest-mods/digilines/blob/master/mod.conf#L2

@BuckarooBanzay
Copy link
Member

BuckarooBanzay commented Sep 20, 2022

it does "work" without mesecons

Sooo, this is still an issue then? see first post

EDIT: nevermind, didn't see the commit 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants