Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repairing teleport tubes w/ a hammer doesn't restore them to functionality. #46

Closed
fluxionary opened this issue Oct 4, 2022 · 8 comments · Fixed by #49
Closed

repairing teleport tubes w/ a hammer doesn't restore them to functionality. #46

fluxionary opened this issue Oct 4, 2022 · 8 comments · Fixed by #49
Assignees
Labels
bug Something isn't working

Comments

@fluxionary
Copy link
Member

a player reports:

When a sender teleport tube (tp) is broken, use hammer to repair. Now the tp tube sender is not working anymore. Expected: tp tube sender should tp the items as it did before breaking, doesn't work even after setting the channel name again. Workaround: destroy the receiver tube and then place it again and configure to get the sender tp tube working again.

@S-S-X
Copy link
Member

S-S-X commented Oct 5, 2022

Looks like #36, if this is happens with up to date version then I guess that functionality is now broken.

@fluxionary
Copy link
Member Author

Looks like #36, if this is happens with up to date version then I guess that functionality is now broken.

server is using b6c02ac, which is after #37, might be a regression.

@BuckarooBanzay BuckarooBanzay added the bug Something isn't working label Oct 6, 2022
@fluxionary
Copy link
Member Author

fluxionary commented Oct 25, 2022

i recently discovered there's a separate issue that causes receive tubes to get delisted from the teleport db, if mod_storage fails to serialize w/ a file-based backend, due to the db getting too large for LuaJIT. it's possible it affected this issue as well, i haven't done any thorough testing.

@TurkeyMcMac
Copy link
Contributor

The move to mod storage was supposed to avoid the LuaJIT size limit. Each entry is serialized individually by Lua. Could you provide more details of this error?

@fluxionary
Copy link
Member Author

The move to mod storage was supposed to avoid the LuaJIT size limit. Each entry is serialized individually by Lua. Could you provide more details of this error?

possibly i'm wrong, it looks like the file-based metadata is being stored in JSON and not via minetest.serialize.

@fluxionary
Copy link
Member Author

in any event, for some reason, the "receive" tubes are disappearing from the tube DB "randomly" (which might be after a server restart). i still suspect this is because things aren't being written cleanly when using the file-based backend when the server crashes.

@TurkeyMcMac
Copy link
Contributor

The mod storage should be written unless there is an abnormal crash without a backtrace etc.

@fluxionary
Copy link
Member Author

The mod storage should be written unless there is an abnormal crash without a backtrace etc.

yup, that does happen from time to time. moving to sqlite backend should (mostly) make that a non-issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants