Breaking up flowers_plus mod #5
Conversation
|
Also, there were some aliases defined at the bottom of the original init.lua, for compatibility when the farming mod came out and deprecated some things that were in this mod. These aliases were 4-8 years old, so I think it's safe to remove them now. |
|
if your going to create new mods, it is probably best to namespace them, especially considering how generic that names are. for example pl_seaweed, pl_waterlily, pl_sunflowers |
|
at least from https://content.minetest.net/metapackages/flowers_plus/ it seems the depreciating the flowers_plus modname is ok |
|
Good point, will rename them. |
|
Done, prefixed with "plantlife_" as that seems to be the convention with other modpacks. |
|
Added settings for each mod to control spawning. |
|
Since the along_shore mod does nothing, since it was all moved into flowers_plus a long time ago, I've removed it. Also fixed plantlife_seaweed since it was generating "along_shore:seaweed" items, and then aliasing them to the "flowers:seaweed" items. |
might be a bit nit picky, but i would suggest a two letter abbreviation as it prevent you from having massive modnames. see nodecore, farlands_reloaded, mineclon*, etc. |
|
The longest is plantlife_waterlilies which is 21, you sure that's too long? |
|
I think it makes it much clearer what actual modpack it's from. |
|
Eh ok I'll rename them. |
Splitting up flowers_plus into separate mods for seaweed, sunflowers and waterlillies, for clarity and so the user can disable them individually. Fixed sunflower maximum heat. Removed spawning, as we're already creating these things at worldgen. Added settings for rarity and max count to each mod - waterlilies, seaweed and sunflowers Removing along_shore mod as it does nothing now.
|
Done. |
|
Sorry to bump but does this require anyone else's approval? |
Don't think so (i don't use that mod anywhere but the changes look good 👍) |
Splitting up flowers_plus into separate mods for seaweed, sunflowers and waterlilies, for clarity and so the user can disable them individually.
Fixed sunflower maximum heat.
Removed spawning, as we're already creating these things at worldgen.