Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit-pick-bicker: Translated strings don't print well to console/log #6

Closed
SwissalpS opened this issue Feb 24, 2022 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@SwissalpS
Copy link
Contributor

print(S("[UnifiedDyes] Loaded!"))

Translating debug mesages doesn't make debugging easier either.

The common syntax using '[...]' seems to be symbolizing a mod, so print('[unifieddyes] loaded') would be the way most filters expect the message.

It's not important though, it just grabbed my attention when looking at the translation file.

@wsor4035
Copy link
Contributor

trival to leave it or remove it. the rest of the logs are going to most likely be in english, so at this time i dont see a reason for it to be translated. however it probably should be updated to use minetest.log to follow minetest log levels

@SwissalpS
Copy link
Contributor Author

The output isn't translated. Output is the original string wrapped in translator markers.
Terminals try to deal with the escape sequence and depending on the mod, it finds something valid or not.

Yes, cleanest would probably be to use minetest.log('info', '[unifieddyes] loaded') but I'm not sure that's the intention of this line.
log lines are not output to stdout.
It seems to me, that generally this 'mod has loaded' line is output to stdout and not logs. It gives a nice quick overview of which mods loaded without having to scour the log file.

@wsor4035
Copy link
Contributor

wsor4035 commented Feb 24, 2022

...print goes to logs

EDIT: disregard this

@OgelGames
Copy link
Contributor

...print goes to logs

No, it doesn't, even with the log level set to verbose.

@wsor4035
Copy link
Contributor

it appears that you are correct. for some reason i thought it went to logs

@BuckarooBanzay BuckarooBanzay added the bug Something isn't working label Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants