Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add collage margin #2

Open
muZk opened this issue Oct 22, 2019 · 3 comments
Open

Add collage margin #2

muZk opened this issue Oct 22, 2019 · 3 comments
Labels
hacktoberfest

Comments

@muZk
Copy link
Collaborator

muZk commented Oct 22, 2019

In react-photo-gallery there is a small space between each image in the preview from README.md.

This is called margin and it is used here and passed down here.

By adding this margin, the width and height of the resulting image will be different. The same with the position of each image in the collage. It should consider the new positions here
@Anilpandiya
Copy link

I can work on this issue.

@muZk
Copy link
Collaborator Author

muZk commented Oct 22, 2019

Ok!

@Anilpandiya
Copy link

Development is done and raised PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@muZk @Anilpandiya