Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better handle error state during command edit #103

Closed
daretodave opened this issue May 9, 2024 · 0 comments · Fixed by #102
Closed

better handle error state during command edit #103

daretodave opened this issue May 9, 2024 · 0 comments · Fixed by #102
Labels
back-end backend work ready
Milestone

Comments

@daretodave
Copy link
Contributor

steps to repo:

  • open editor for command file
:cmd

-add an error to the typescript (e.g invalid character, or misspell void/async)

  • save

mterm will indicate "commands saved" but it could not reload due to the error. you can see this is you look at the yarn dev output

todo:

  • wrap :cmd logic with a try/catch and display error in a way that the user can see it
  • see if :settings edit has the same issue maybe?
    • run :settings edit
    • see if adding a bogus json character etc will say "settings saved"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end backend work ready
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant