Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting of source code sections seems not to work for PDF #19

Closed
dietmarw opened this issue Jan 2, 2014 · 8 comments
Closed

Highlighting of source code sections seems not to work for PDF #19

dietmarw opened this issue Jan 2, 2014 · 8 comments

Comments

@dietmarw
Copy link
Collaborator

dietmarw commented Jan 2, 2014

I noticed that highlighted source code lines will not appear highlighted in the generated LaTeX/PDF version. I looked at the writer/latex.py from Sphinx where this functionality is actually present as of version 1.2.

So something to look into at some point.

@tbeu
Copy link
Contributor

tbeu commented Apr 20, 2014

Issue confirmed.

@dietmarw
Copy link
Collaborator Author

There is already an issue on sphinx-doc/sphinx#1238

@tbeu
Copy link
Contributor

tbeu commented Apr 21, 2014

This does not look too promissing since Pylons/pyramid#667 was opened 20 months ago.

@dietmarw
Copy link
Collaborator Author

Not likely go get fixed soon. So bumping to the next milestone so we can revisit it again.

@dietmarw dietmarw modified the milestones: 0.5.0, 0.6.0 Nov 17, 2017
@xogeny
Copy link
Collaborator

xogeny commented Nov 21, 2017

Seems like this is beyond our control, no? So it really doesn't need to be in our issue tracker if it is already in theirs. Presumably once there is an upstream fix, it will eventually trickle down to us. Or do you think this is simple enough that we could somehow fix it?

@dietmarw
Copy link
Collaborator Author

It might be beyond our control but we still need a reminder to check the newer versions of sphinx in case this has been fixed so that we can update the docker configuration. So I suggest to keep this ticket and just move it from milestone to milestone after checking.

@dietmarw
Copy link
Collaborator Author

This will be fixed for Sphinx 1.6.6 though there is currently just a small issue that is being worked on. Once that is fixed we can update the book-builder to use 1.6.6 and configure the background colour to the same as the HTML uses

# Set line highlight background to light yellow
    'sphinxsetup': 'VerbatimHighlightColor={rgb}{1,1,0.8}',

😄

@dietmarw
Copy link
Collaborator Author

So this is now already fixed in the stable development branch. We now just need to wait for the 1.6.6 release to update the xogeny/book-builder and then the PDFs will als have highlighted lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants