Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with PerfectPixel addon? #1

Closed
kexes opened this issue Apr 28, 2024 · 2 comments · Fixed by #2
Closed

Compatibility with PerfectPixel addon? #1

kexes opened this issue Apr 28, 2024 · 2 comments · Fixed by #2

Comments

@kexes
Copy link

kexes commented Apr 28, 2024

I know its not your responsibility, but you wrote at the Font Changer addon on ESOUI site that you can look into the PP support if anyone need to.

So here is the thing:

I tried the original Font Changer PP version first, but i had .lua errors with it which i think caused by another addon called the Bandit User Interface which also im using (posted the error logs on the ESOUI site), so i tried your forked version and its working without any issues or any .lua errors, except that some elements of the whole UI system are still using the default ESO font type instead of the new ones. When i disable the PP addon the UI will start using the new fonts where its not there before, so im sure your fork just needs the proper support for PP.

Here are some example screenshots:

interact
inventory
quests
skills

@mtking2
Copy link
Owner

mtking2 commented Apr 28, 2024

@kexes I'm working on adding support for these. Thank you for these screenshots! They are super helpful.

I think I've gotten PerfectPixel working great so far and I hope to find some time soon to work on Bandits UI.

PR: #2

@mtking2
Copy link
Owner

mtking2 commented Apr 28, 2024

@kexes no issues with Bandits UI!

Here is v1.5

Bandits UI has its own font settings so I am not going to try to put any overrides on it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants