Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky update detection through socket.io #596

Closed
mtlynch opened this issue Mar 18, 2021 · 0 comments · Fixed by #632
Closed

Flaky update detection through socket.io #596

mtlynch opened this issue Mar 18, 2021 · 0 comments · Fixed by #632
Labels
bug Something isn't working
Milestone

Comments

@mtlynch
Copy link
Contributor

mtlynch commented Mar 18, 2021

Description

Users who upgrade from pre 975a64a to post 975a64a will see the "Restarting to complete update" spinner forever.

This is because 975a64a upgraded the client and server to use a version of the socket.io protocol that is not backwards-compatible with previous clients. After the update, the server has the new version of the protocol, but the JS client still has the old version until they reload the page.

We should switch to an HTTP-based solution (e.g., querying GET /api/status). HTTP is much less likely to have version incompatibilities no matter what library we update to.

What's the behavior that you expect?

Update completes successfully.

What's happening instead?

Update hangs on the waiting for restart page.

What are the steps to reproduce this behavior?

  1. Install TinyPilot 1.4.0
  2. Click on System > Update
  3. Proceed with the update prompts
@mtlynch mtlynch added the bug Something isn't working label Mar 18, 2021
@mtlynch mtlynch added this to the 1.4.2 milestone Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant