Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round input MIDIs to 48 (or 24?) ticks per beat #4

Open
mtolly opened this issue Jun 10, 2014 · 1 comment
Open

Round input MIDIs to 48 (or 24?) ticks per beat #4

mtolly opened this issue Jun 10, 2014 · 1 comment
Assignees

Comments

@mtolly
Copy link
Owner

mtolly commented Jun 10, 2014

Probably the input MIDI tracks should be rounded to 48 ticks per beat, because this is the natural resolution of the Red/Blue engine. A note/rest length is (number of ticks) * (notetype speed) / 48 of a beat. Input MIDIs are usually stored at a resolution of 480, 960, or something similar, so this would allow events in them to be one tick off with no problems.

This should be done with discretize from the event-list library to avoid compounding rounding errors.

@mtolly mtolly self-assigned this Jun 10, 2014
@mtolly mtolly mentioned this issue Jun 10, 2014
@mtolly mtolly changed the title Round input MIDIs to 48 ticks per beat Round input MIDIs to 48 (or 24?) ticks per beat Oct 25, 2014
@mtolly
Copy link
Owner Author

mtolly commented Oct 25, 2014

As per #9, 48 ticks per beat may not be safe. A resolution of 24 ensures that all durations can be translated correctly, but at the cost of not allowing some otherwise legal durations. 24 should be fine though; none of the game's built-in songs require a 48 resolution, and 24 still gives you plenty of possible subdivisions (for example, 32nd notes and 32nd note triplets are both fine).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant