Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggesting a patch for the pom files concerning tests #13

Closed
pgrt opened this issue Jul 26, 2020 · 2 comments
Closed

Suggesting a patch for the pom files concerning tests #13

pgrt opened this issue Jul 26, 2020 · 2 comments

Comments

@pgrt
Copy link

pgrt commented Jul 26, 2020

Hello,

While building with Maven 3.6, I encountered issues related to the type test-jar in the pom files. Replaging those type lines with tests solved the issue. You may find my patch proposal enclosed.

All the best,
Pierre

managing_test_dependency.txt

@mtommila
Copy link
Owner

What issues does using the dependency type test-jar cause? I fail to understand how it would be more correct to use <classifier>tests</classifier> instead of <type>test-jar</type>?

@pgrt
Copy link
Author

pgrt commented Aug 18, 2020

Hello,

My build was attempted within the automated Maven workflow in Debian, with the aim of packaging apfloat for Debian. By using <type>test-jar</type>, the submodules could not load the test jar and the issue was solved by using the classifier approach instead.
But if you don't meet this issue, I guess it is specific to the Debian packaging workflow and the patch I have written should not be used outside. The issue can thus be closed.

Best,
Pierre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants