Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Error parsing non-float episodes #23

Open
baxa73 opened this issue Jan 5, 2020 · 5 comments
Open

Error parsing non-float episodes #23

baxa73 opened this issue Jan 5, 2020 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@baxa73
Copy link

baxa73 commented Jan 5, 2020

FETCHING: Re Zero kara Hajimeru Isekai Seikatsu - Director's Cut
Process Process-2:
Traceback (most recent call last):
File "/usr/lib/python3.6/multiprocessing/process.py", line 258, in _bootstrap
self.run()
File "/usr/lib/python3.6/multiprocessing/process.py", line 93, in run
self._target(*self._args, **self._kwargs)
File "/usr/local/lib/python3.6/dist-packages/HorribleDownloader/cmd.py", line 121, in fetch_episodes
new = list(filter(lambda s: ep_filter(s["episode"]), episodes))
File "/usr/local/lib/python3.6/dist-packages/HorribleDownloader/cmd.py", line 121, in
new = list(filter(lambda s: ep_filter(s["episode"]), episodes))
File "/usr/local/lib/python3.6/dist-packages/HorribleDownloader/cmd.py", line 86, in generated_filter
return any([test(float(ep)) for test in tests])
File "/usr/local/lib/python3.6/dist-packages/HorribleDownloader/cmd.py", line 86, in
return any([test(float(ep)) for test in tests])
ValueError: could not convert string to float: '01B'
Couldn't find specified anime. Exiting

@mtshrmn mtshrmn added the bug Something isn't working label Jan 9, 2020
@mtshrmn
Copy link
Owner

mtshrmn commented Jan 9, 2020

Thank you for using horrible-downloader!
Can you please tell me what did you do, what is the expected result and what os are you using?

@baxa73
Copy link
Author

baxa73 commented Jan 9, 2020

Downloaded title "Re Zero kara Hajimeru Isekai Seikatsu - Director's Cut", then I got this error.
All is well with the other titles.

Downloaded with this command: (horrible-downloader -d "Re Zero kara Hajimeru Isekai Seikatsu - Director's Cut" -e 1)

OC: Ubuntu 16.04.6 LTS (GNU/Linux 4.4.0-169-generic x86_64)

@baxa73
Copy link
Author

baxa73 commented Jan 9, 2020

I think the problem is that on the same page, the place immediately two different versions and so the loader cannot understand which one to pump out.

@mtshrmn
Copy link
Owner

mtshrmn commented Jan 12, 2020

I will try to work on a solution this week. Sorry for keeping you waiting.

@mtshrmn mtshrmn added this to the Version 1.1.0 milestone Apr 25, 2020
@mtshrmn mtshrmn removed this from the Version 1.1.0 milestone Jun 23, 2020
@mtshrmn mtshrmn added wontfix This will not be worked on and removed bug Something isn't working labels Jun 23, 2020
@mtshrmn mtshrmn closed this as completed Jun 23, 2020
@mtshrmn
Copy link
Owner

mtshrmn commented Jul 11, 2020

The new re:zero season brought back this issue. It's a bit annoying having letters in the title and parsing it is weird.
horriblesubs.info don't sort stuff logically and it's adding to the complexity. It would be nice to solve this issue but because this is happening only with this specific anime, I prefer to just ignore it.

If anyone wants to try and tackle the problem, go ahead, I'll be glad.

@mtshrmn mtshrmn changed the title error Error parsing non-float episodes Jul 11, 2020
@mtshrmn mtshrmn added bug Something isn't working help wanted Extra attention is needed and removed wontfix This will not be worked on labels Jul 11, 2020
@mtshrmn mtshrmn reopened this Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants