Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera Parameters #1

Open
mohamadmarjani97 opened this issue Dec 2, 2020 · 1 comment
Open

Camera Parameters #1

mohamadmarjani97 opened this issue Dec 2, 2020 · 1 comment

Comments

@mohamadmarjani97
Copy link

hello Mateusz
I download your code and run it. it was great.
I have some question about Camera Parameters. my first question is what are the "baseline=59.8896" ,"doffs=0" and "ndisp=942"?
"camera.txt" and "images.txt" are necessary for running? I want to use my images to run this code and I want to know that's enough to fix Camera parameters? or I need to to Other?
Thank you

@mtszkw
Copy link
Owner

mtszkw commented Dec 3, 2020

Hi,

Data comes from ETH3D datasets and its elements (cameras.txt and images.txt) are documented in ETH3D documentation. Two-view dataset that I use also comes with calib.txt file that contains parameters you mentioned (baseline, doffs, ndisp, ...). Description of calib.txt contents can be found in Middlebury data format documentation.

doffs: x-difference of principal points, doffs = cx1 - cx0

baseline: camera baseline in mm

ndisp: a conservative bound on the number of disparity levels;
the stereo algorithm MAY utilize this bound and search from d = 0 .. ndisp-1

Honestly, I dont' really remember what's the final status of the code, but if the version available here works well for you, then I think you only need data that's really used there. So cameras.txt and images.txt seem unnecessary, but baseline value is used in the notebook for constructing Q matrix.

BTW I'm really curious if this code works with your images, please let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants