Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsound uses of Unsafe #56

Closed
r4klatif opened this issue Aug 25, 2021 · 2 comments
Closed

Unsound uses of Unsafe #56

r4klatif opened this issue Aug 25, 2021 · 2 comments

Comments

@r4klatif
Copy link

Right now the hello-world code contains 100+ uses of unsafe. Presumably this is in order to achieve the best possible performance in hot parts of the code.

However, Hello worlds often face the modern and memory safe🔒 rust 🚀 programmer, so security🔒 is extremely important for hello world implementations. This issue is especially critical for organizations that intend to use the software in large-scale🚀 production environments. One of the main reasons to choose a Rust🚀-based hello world implementation is the guaranteed memory safety🔒 that safe Rust🚀 provides. Unfortunately this guarantee is eroded for every use of unsafe in the codebase. Performance isn't worth much if it comes at the cost of critical security vulnerabilities due to unsafe memory access. It's also nice to know for certain that your hello world won't segfault in production.

I propose that we leave this open as a tracking issue to track design and implementation issues concerning the use of unsafe code. Some of the items that should be explored:

  • Is it possible to remove any of the current uses of unsafe without significantly impacting performance?
  • Is it appropriate to remove some uses of unsafe even if there's a performance impact?
  • Is there a long-term plan to reduce or eliminate the use of unsafe code?
  • Security🔒 analysis, testing, and fuzzing of the codebase
  • Profiling and performance analysis to assess the impact of converting unsafe to safe code
@mTvare6
Copy link
Owner

mTvare6 commented Aug 25, 2021

Did you read the readme? rust can convert unsafe c to safe c, and unsafe assembly code to safe assembly code, the same way, all unsafe code is converted to safe code, don't worry, we will have the performance and safety 🚀

@mTvare6
Copy link
Owner

mTvare6 commented Aug 30, 2021

Duplicate of #22

@mTvare6 mTvare6 marked this as a duplicate of #22 Aug 30, 2021
@mTvare6 mTvare6 closed this as completed Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants