Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support spherical honeycombs #18

Open
roice3 opened this issue Apr 5, 2018 · 2 comments
Open

Support spherical honeycombs #18

roice3 opened this issue Apr 5, 2018 · 2 comments
Assignees

Comments

@roice3
Copy link
Collaborator

roice3 commented Apr 5, 2018

We need a set of methods like the current hyperboloid methods, but for S^3.

My main question: Do we want to try to mash this all into one shader, or do we want a separate shader for the spherical (and maybe euclidean) cases? A separate shader would avoid some branching within the shader execution, but that might be trivial performance-wise. I'm leaning towards two separate shaders, one for spherical+euclidean, and a second for hyperbolic. We could, however, share some of the include shader files between the two.

@henryseg
Copy link
Collaborator

henryseg commented Apr 5, 2018

Let's not stop at hyperbolic, spherical and euclidean - there are the other five Thurston geometries to do as well.

@henryseg
Copy link
Collaborator

henryseg commented May 8, 2018

I think euclidean would be a good next case - it will make clear how things should be abstracted so as to leave as few possible differences between the geometries as possible.

@roice3 roice3 self-assigned this May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants