Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make javascript and glsl Minkowski signature consistent #9

Closed
roice3 opened this issue Mar 21, 2018 · 1 comment
Closed

Make javascript and glsl Minkowski signature consistent #9

roice3 opened this issue Mar 21, 2018 · 1 comment

Comments

@roice3
Copy link
Collaborator

roice3 commented Mar 21, 2018

This is just to remind us about this code cleanup need.

It's +++- in the javascript, and ---+ in the glsl

(slightly related: it's a bummer that I had to add a separate lorentzDot method for the three.js vector structure. I wonder if there might be a way to avoid that.)

@mtwoodard
Copy link
Owner

Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants