Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Completions not returning all tables #1118

Open
1 of 6 tasks
TylerR909 opened this issue Mar 10, 2023 · 3 comments
Open
1 of 6 tasks

Table Completions not returning all tables #1118

TylerR909 opened this issue Mar 10, 2023 · 3 comments
Labels

Comments

@TylerR909
Copy link

Describe the bug

We evidently have 253 tables but when I type SELECT * FROM , Intellisense is only offering me some of my tables. Per Output debug I can see:

[1678406221628] INFO  (ext): EXECUTING COMMAND => sqltools.getConnections
[1678406221629] INFO  (ls): REQUEST RECEIVED => connection/GetConnectionsRequest
[1678406225456] INFO  (ls): completion requested {"line":1,"character":15}
    ns: "intellisense"
[1678406225464] INFO  (ls): got got %d db completions
    ns: "intellisense"
[1678406225500] INFO  (ls): got 100 table completions
    ns: "intellisense"

If I type out a table that won't show up in Intellisense, and then continue on to fill out WHERE or SELECT then intellisense does give me proper column intellisense.

To Reproduce
Steps to reproduce the behavior:

  1. Make a couple hundred tables
  2. Type SELECT * FROM and prompt Intellisense to suggest a table
  3. Not all the tables are there
    1. Results appear to be alpha sorted

Expected behavior
All my tables appear in Intellisense

Desktop (please complete the following information):

  • SQLTools Version: v0.27.1
  • VS Code Version: 1.76.0
  • OS: OSX
  • Driver:
    • PostgreSQL/Redshift
    • PostgreSQL/Cockroach
    • MySQL/MariaDB
    • MSSQL/Azure
    • SQLite
    • Other? Which...
  • Database version: [e.g. MySQL v5.6, PostgreSQL vX...]
    • PostgreSQL 13.4 (Debian 13.4-4.pgdg110+1) on aarch64-unknown-linux-gnu, compiled by gcc (Debian 10.2.1-6) 10.2.1 20210110, 64-bit

Additional context

I've tried setting "sqltools.results.limit": 200, but no joy

@TylerR909
Copy link
Author

Almost a year later. I just retried with CockroachDB and the Postgres drivers and it still can't intellisense anything past the first 100 tables. I use intellisense to explore and branch out to see what my options are. This is unusable with a limit that low. We're up to 319 tables now describing various entities, many-to-many relationships, Enumeration tables, etc. The inability to see past "E" in an alpha-sorted table intellisense is pretty rough.

@gjsjohnmurray
Copy link
Collaborator

If you type an initial letter (e.g. T) before invoking Intellisense do you get shown up to 100 choices beginning with that letter?

@TylerR909
Copy link
Author

Nope. I have a table called projects which alphasorted clocks in at 225.

SELECT * from p does not offer that table up. It's suggesting tables with p in the name, like activity_type, but it's acting like it loaded the first 100 tables, cached those, and now Intellisense is only searching those cached tables. I have 31 other tables that look like project_status or project_team_member etc and none of them are suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants