Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofill name and group when bookmarking #1137

Open
djbrown opened this issue Apr 23, 2023 · 0 comments
Open

Autofill name and group when bookmarking #1137

djbrown opened this issue Apr 23, 2023 · 0 comments
Labels
feature request New issue opened using "Feature request" template

Comments

@djbrown
Copy link

djbrown commented Apr 23, 2023

When I edit an existing Bookmark, the metadata (group and name) is pasted into the Editor:

-- @block Bookmarked query
-- @group Some Group
-- @name My Query

delete from my_table;

Prevent duplication

When I select the block via the UI button, it also selects those metadata comments.
When bookmarking that selection into a new bookmark, the previous comments will be saved too, cluttering the new bookmark and creating a separate block.

-- @block Bookmarked query
-- @group Some Group
-- @name NEW Query

-- @block Bookmarked query
-- @group Some Group
-- @name My Query

delete from my_table;

So the first improvement would be to not copy those previous comments to the new bookmark:

-- @block Bookmarked query
-- @group Some Group
-- @name NEW Query

delete from my_table;

Prefill bookmarking popups

Secondly, it would be super nice to have the popups for group and name autofilled with the values of the comments.
The popup value should be selected tough, so you can easlily override the prefilled values:
grafik

If no metadata comments are includet in the selection for bookmarking, then the current behaviour may be kept:
Blank query name and prefilled group "Ungrouped".

@djbrown djbrown added the feature request New issue opened using "Feature request" template label Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New issue opened using "Feature request" template
Projects
None yet
Development

No branches or pull requests

1 participant