Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node runtime detection fails when oh-my-zsh update is available #1187

Open
5 tasks
robertrossmann opened this issue Jul 17, 2023 · 0 comments
Open
5 tasks
Labels

Comments

@robertrossmann
Copy link

Describe the bug
Node runtime detection seems to spawn an interactive shell, and if that shell asks a question the detection may fail.

To Reproduce
Steps to reproduce the behavior:

  1. Start VS Code with sqltools installed
  2. Have the shell ask you a question (for me, it's the oh-my-zsh update confirmation)
  3. Notice that the first character of the node version detection is consumed by the question and the command that is actually executed is therefore incorrect (see screenshot)
  4. Node version detection fails

Expected behavior
The node detection is executed from a non-interactive shell so that other programs running in it know not to ask questions.

Screenshots

Screenshot 2023-07-17 at 9 46 17

Desktop (please complete the following information):

  • SQLTools Version [e.g. v0.17.x]: v0.28.0
  • VS Code Version: [e.g 1.x.y]: 1.80.1
  • OS: [e.g. Windows, Linux, Mac]: Mac x86
  • Driver:
    • PostgreSQL/Redshift
    • MySQL/MariaDB
    • MSSQL/Azure
    • SQLite
    • Other? Which...
  • Database version: [e.g. MySQL v5.6, PostgreSQL vX...]

Additional context

None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant