Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping default vscode Intellisense in autocompletion #135

Closed
mickeypearce opened this issue Mar 12, 2019 · 6 comments
Closed

Keeping default vscode Intellisense in autocompletion #135

mickeypearce opened this issue Mar 12, 2019 · 6 comments
Labels
feature request New issue opened using "Feature request" template

Comments

@mickeypearce
Copy link
Contributor

mickeypearce commented Mar 12, 2019

Is your feature request related to a problem? Please describe.
Autocompletion of DB objects (tables, columns, ...) by SQLTools is really nice. But I miss variables, medhods, ... from my code that VS Code provides in IntelliSense by default.

Describe the solution you'd like
Keep default VS Code autocompletion AND SQL tools DB objects autocompletion

Describe alternatives you've considered

Additional context

If it is possible to have both: Default IntelliSense and SQLTools DB objects autocompletion at the same time it would be perfect!

@mickeypearce mickeypearce added the feature request New issue opened using "Feature request" template label Mar 12, 2019
@benyaminl
Copy link

benyaminl commented Mar 12, 2019

Hey pearce, for now implementing intelisense itself is quite dificult task for Mat, maybe you could help him a little bit more with supporting via patreon https://www.patreon.com/mteixeira to help fund this project so mat have more time to implement such request :) It's a great feature anyway :) 👍

@mtxr
Copy link
Owner

mtxr commented Mar 12, 2019

Thanks @benyaminl!

@mickeypearce there is an issue (and a branch) fo this. It's a bit hard because of the variety of SQL parsers around. MySQL has some specific stuff, MSSQL too and PostgreSQL as well.

So I want to work it deeper to make it dialect independent. It's a loot of work, but now with the plugin architecture should be easier.

I'll close this i favor of #110, ok?

Feel free to reopen if you believe it's not related.

Thanks!

@mtxr mtxr closed this as completed Mar 12, 2019
@mickeypearce
Copy link
Contributor Author

mickeypearce commented Mar 12, 2019

Just for clarifiaction... It would be nice to have it both at the same time (1. and 2.):

  1. VS Code's word based completions (without SQL Tools or not connected):
    image

  2. SQL Tools autocompletion of DB objects (l_myparam is not on the list anymore):(
    image

I thought it is not a problem to keep the default autocompletion, but It might be a VS Code issue that is not possible to extend the defaults...

@mtxr
Copy link
Owner

mtxr commented Mar 14, 2019

Thanks @mickeypearce .

The idea is to keep both. Just one is not an option. For example, I use VSCode completions and SQLtools completions in my JS/TS files, and this is possible just If both are working.

I found a great SQL parser, it's just for SQLite, but I'm working on extending to other dialect to make it a bit easier. From scratch is almost impossible for me now

1 similar comment
@mtxr
Copy link
Owner

mtxr commented Mar 14, 2019

Thanks @mickeypearce .

The idea is to keep both. Just one is not an option. For example, I use VSCode completions and SQLtools completions in my JS/TS files, and this is possible just If both are working.

I found a great SQL parser, it's just for SQLite, but I'm working on extending to other dialect to make it a bit easier. From scratch is almost impossible for me now

@mickeypearce
Copy link
Contributor Author

mickeypearce commented Mar 15, 2019

Ok. thanks @mtxr .
Maybe consider also using CompletionItemProvider (vscode.languages.registerCompletionItemProvider, ...) as it allow multiple providers for a lang.

@benyaminl benyaminl mentioned this issue Sep 5, 2019
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New issue opened using "Feature request" template
Projects
None yet
Development

No branches or pull requests

3 participants