Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concern toward rendering HTML content in cells #29

Closed
5 of 7 tasks
sluongng opened this issue Sep 17, 2017 · 0 comments
Closed
5 of 7 tasks

Concern toward rendering HTML content in cells #29

sluongng opened this issue Sep 17, 2017 · 0 comments
Assignees

Comments

@sluongng
Copy link

This is a guideline to help us to understand SQLTools Issues.

You don't need to stick to this, but please try to guide us to reproduce the errors or understand your feature requests.

Issue Type

  • Feature Request
  • Bugfix/Errors
  • Questions
  • Other

Prerequisites (For bugfixes)

  • Are you running the latest version?
  • Did you check the logs?
  • Did you check the Setup?

Description

Currently the SQLTools results page is rendering HTML contents(including images and videos) which was store in the row.
This should be avoided because these HTML could have malicious user generated contents among them.
I am suggesting to have the text output(similar in sublime) to be enabled by default and have HTML rendering to be enable as a user option.
Currently I am querying thousands of rows and each rows may have multiple images, autoplay videos... to be rendered. This not only affect performance of my machine but also security.

Steps to Reproduce (For bugfixes)

  1. Create a table in which have a column type text
  2. Insert a row with said column containing HTML contents(images, videos autoplay etc...)
  3. Query that row with SQL Tools

Expected behavior: Should generate text content similar to mysql CLI or sqltools in sublime text

Actual behavior: HTML contents being rendered in VS Code window, videos being autoplayed.

Versions

  • Version: Using SQLTools v0.5.1
  • OS: Ubuntu 16 LTS
  • SGDB: MySQL

You can get this information from executing SQLTools: Version from VSCode Quick Open.

@mtxr mtxr self-assigned this Dec 14, 2017
@mtxr mtxr mentioned this issue Jan 2, 2018
@mtxr mtxr closed this as completed Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants