Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOP adding debug env #644

Closed
1 of 5 tasks
dreamerblue opened this issue Jul 5, 2020 · 1 comment
Closed
1 of 5 tasks

STOP adding debug env #644

dreamerblue opened this issue Jul 5, 2020 · 1 comment
Labels

Comments

@dreamerblue
Copy link

Describe the bug

Please DO NOT add debug env so that the vscode remote server will be effected by this.

And user's dev progress will output so many useless logs.

For example, when I installed SQLTools in remote server, and start a Node.js debug progress via npm run dev, the terminal outputs so many installed dependencies debug logs which are unexpected and noisy.

To Reproduce
Steps to reproduce the behavior:

  1. Install Remote - SSH ext and open a remote project
  2. Open a new terminal window after SQLTools activated
  3. Output the process.env.DEBUG in Node.js or run echo $DEBUG
  4. It outputs *,-*:debug,-*:*:debug,-*:*:*:debug,-*:*:*:*:debug,-*:*:*:*:*:debug or *,-babel*,-*:debug,-*:*:debug,-*:*:*:debug,-*:*:*:*:debug,-*:*:*:*:*:debug

Expected behavior
No debug env added.

Screenshots
screenshot-vscode-remote-debug-env

Desktop (please complete the following information):

  • SQLTools Version 0.22.10
  • VSCode Version: 1.46.1
  • OS: macOS 10.15.5 (local) and Ubuntu 18.04 (remote)
  • Driver:
    • PostgreSQL/Redshift
    • MySQL/MariaDB
    • MSSQL/Azure
    • SQLite
    • Other? Which...
  • Database version: [e.g. MySQL v5.6, PostgreSQL vX...]

Additional context
Related issue: microsoft/vscode-remote-release#3091

@mtxr
Copy link
Owner

mtxr commented Jul 23, 2020

I'll replace debug lib by another one. This is not something done intentionally but when I call debug.enable it's setting the env variable..

@mtxr mtxr closed this as completed in 67d5333 Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants