Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]Firebird Support #73

Closed
3 tasks
LiPengfei19820619 opened this issue Mar 23, 2018 · 4 comments
Closed
3 tasks

[Feature Request]Firebird Support #73

LiPengfei19820619 opened this issue Mar 23, 2018 · 4 comments
Labels
feature request New issue opened using "Feature request" template rdbms dialect

Comments

@LiPengfei19820619
Copy link

Issue Type

  • [* ] Feature Request
  • Bugfix/Errors
  • Questions
  • Other

Would you please support Firebird Database? Thanks.

@mtxr mtxr added the feature request New issue opened using "Feature request" template label Apr 18, 2018
@mtxr
Copy link
Owner

mtxr commented Jun 6, 2018

Hey @LiPengfei19820619, could you please submit a pull request of this feature?

As you are a user that understands the needs for Firebird, you could follow this commit 6cc9774 and use this lib hgourvest/node-firebird to accomplish the same result that I've got with Postgres. Is it ok?

As you can see at the commit, it's not difficult, it's almost to define the queries it needs to run.

Thanks!

@mtxr mtxr self-assigned this Jun 6, 2018
@Level0r0s
Copy link

I did the Firebird Interface implementation.

As I have no experience with extensions and do not know how to test.
@mtxr It would be possible to test and upgrade the master.

Tanks

https://github.com/Level0r0s/vscode-sqltools

@mtxr mtxr removed their assignment Jan 11, 2019
This was referenced Jan 11, 2019
@mtxr mtxr added this to the v0.17.x - next milestone Feb 9, 2019
@mtxr
Copy link
Owner

mtxr commented Mar 1, 2019

@LiPengfei19820619 can you test the open PR?

I believe it's already working, I've updated the references to the new code.

Thanks!

@mtxr mtxr removed this from the v0.17.x - next milestone Mar 1, 2019
@mtxr
Copy link
Owner

mtxr commented Mar 14, 2019

Closing. Needs users to test it.

If someone want to move forward with it, here is the PR #123 and the branch with the code is feature/firebird.

@mtxr mtxr closed this as completed Mar 14, 2019
@MrNicolass MrNicolass mentioned this issue Feb 20, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New issue opened using "Feature request" template rdbms dialect
Projects
None yet
Development

No branches or pull requests

3 participants