-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All slider in jalv.gtk generic ui ignored. #34
Comments
Seems like the plugin is completely ignoring parameter changes EDIT: that's incorrect. that function is a message callback, not the function that is called when a parameter changes. |
Ok, going through the code... helm uses the new juce api to handle plugins: with that the plugin class doesn't need to handle parameter changes directly. when a parameter is changed by the host the 'setValue' function is called: as we see in this line, the listener is registered: so the parameter value does get changed and parameterChanged is called. so perhaps 'setValue' is never called? btw, parameterChanged is calling gui functions and allocating string data, which is really awful for realtime. |
Hmmmm.... Going to have a look at this over the weekend. Maybe I should refactor this a bit so it doesn't use strings. |
Well I finally got around to this bug, but it's actually working for me. Also, the listener callback is just to alert the GUI that a value was changed from the host. The actually value used in synthesis is set here: https://github.com/mtytel/helm/blob/master/src/plugin/value_bridge.h#L47 |
Going to mark this done because it worked for me? |
When running
jalv.gtk --generic-ui http://tytel.org/helm
, Helm doesn't react to the generic ui at all.The text was updated successfully, but these errors were encountered: