Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to implement LoggerFilter #9

Open
mbsimonovic opened this issue Nov 20, 2020 · 1 comment
Open

Not possible to implement LoggerFilter #9

mbsimonovic opened this issue Nov 20, 2020 · 1 comment

Comments

@mbsimonovic
Copy link

There's some mismatch between npm published versions (3.0.12) and git tags, where is 3.0.11 and 3.0.12?

3.0.10 does not export LoggerStatement, so it's impossible to implement LoggerFilter.

3.0.11 changes LoggerFilter interface:

export interface ToRedact { fieldName?: string, value?: string | number }
export interface LoggerFilter {
  redact(toRedact: ToRedact): any;
}

But this is not correct, the ToRedact.value should be any. More importantly this is a breaking change, so should at least be a new minor version, if not major.

Other than that this is almost a perfect match for what I've been looking for, thanks!

@matt-filion
Copy link
Contributor

I never noticed this issue, I apologize for that. LoggerFilter should be getting exported now and there are a couple of included filters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants