Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix truncation of exception traceback #37

Merged
merged 1 commit into from Jun 7, 2016

Conversation

grechut
Copy link
Contributor

@grechut grechut commented Jun 7, 2016

Today we've realized that our API exception tracebacks are being truncated when we have flask-profiler turned on. After short research, we've discovered that the exception's stack trace is rewritten because of the way exception is re-rised.

except Exception as e:
    raise e

Instead of this approach, just blank raise can be used. It keeps the old traceback.

@muatik
Copy link
Owner

muatik commented Jun 7, 2016

Perfect! Thanks for your contribution. I am going to test it and release a bug-fix version on pip.

@drbig
Copy link

drbig commented Jun 7, 2016

We've tested it already, but there is no such thing as too much testing 👍 :D

@muatik muatik merged commit 00c0c56 into muatik:master Jun 7, 2016
@muatik
Copy link
Owner

muatik commented Jun 7, 2016

@drbig :) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants