Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--interesting breaks with some message types #81

Closed
muaddib1984 opened this issue Apr 8, 2022 · 3 comments
Closed

--interesting breaks with some message types #81

muaddib1984 opened this issue Apr 8, 2022 · 3 comments

Comments

@muaddib1984
Copy link

muaddib1984 commented Apr 8, 2022

On the parsing side, I'm also experimenting with --interesting and getting this error

  File "/home/user/iridium-toolkit/iridium-parser.py", line 407, in <module>
    do_input(input)
  File "/home/user/iridium-toolkit/iridium-parser.py", line 291, in do_input
    perline(bitsparser.Message(line.strip()).upgrade())
  File "/home/user/iridium-toolkit/iridium-parser.py", line 361, in perline
    print(q.pretty())
  File "/home/user/iridium-toolkit/bitsparser.py", line 1009, in pretty
    s+= " ["+" ".join(["%s"%x for x in self.descrambled])+"]"
AttributeError: 'IridiumIPMessage' object has no attribute 'descrambled'

this happens with a few other message types. if the line here is changed to this:
if type(q).__name__ == "IridiumMessage" or type(q).__name__ == "IridiumECCMessage" or type(q).__name__ == "IridiumBCMessage" or type(q).__name__ == "Message" or type(q).__name__ == "IridiumSYMessage" or type(q).__name__ == "IridiumMSMessage" or type(q).__name__ == "IridiumIPMessage" or type(q).__name__ == "IridiumLCWMessage" or type(q).__name__ == "IridiumLCW3Message" or q.error:

It doesn't give anymore errors for my particular file. Is that the correct change?

Can you elaborate on what --interesting is doing? I'm going through the source now and re-watching the HOPE talk. just want to get a feel for it's relevance.

@Sec42
Copy link
Member

Sec42 commented Apr 9, 2022

--intresting is just a filter that prints a subset of iridium packets that I (at that time) deemed interesting. You can see the classes in that it selects in that if statement. I'll take a look and fix it later :-)

@Sec42
Copy link
Member

Sec42 commented Apr 11, 2022

Looking at it some more, i don't really remember what that mode was useful for. Your fix is as good as any. I think I'll just remove this mode.

@muaddib1984
Copy link
Author

But by removing --interesting won't that possibly make iridium-toolkit less interesting :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants