Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for this project #60

Open
ChrisBurch opened this issue Jun 25, 2020 · 11 comments
Open

Support for this project #60

ChrisBurch opened this issue Jun 25, 2020 · 11 comments

Comments

@ChrisBurch
Copy link
Contributor

Hi @id2359, @jithendralal,

It looks like you're the two members of the org that this project lives in. There's an appetite to keep this project up to date with newer Django releases (Django 3.0+, #57), but we need someone from your org to either occasionally review PRs, or give another user permissions to do so (e.g: @sztamas offered to do this in our conversation on #57).

I'd love to see this project stay current, please let me know how I can help!
Chris

@sztamas
Copy link
Contributor

sztamas commented Jul 1, 2020

Hi @id2359 ,

Just adding that I am an independent software developer right now and before taking on more projects I would have some time to clean this project up and update it for the currently supported Django versions.

While Django isn't my main focus right now I would like to do "the right thing" for the people who still depend on the project.

Would you mind giving me back control of the project or letting us know if you're not going to do that, so people can at least move on?

Thanks,

Tamas

@petedermott
Copy link

petedermott commented Aug 21, 2020

Hi @sztamas ,

Since it looks like no one from Murdoch U is active on this project these days, is there a chance that we could fork this project and repackage it as a "-redux" version that can have some of the new PRs merged in?

It's a useful package that I use on a few projects and it would be nice if it was kept alive for a little while longer.

@sztamas
Copy link
Contributor

sztamas commented Aug 23, 2020

Hi @petedermott ,

Yes, that is doable, I started a fork (https://github.com/sztamas/django-iprestrict-redux) and did some initial work on it.
There are quite a few things to get rid of and clean up so it there are a bit more changes than expected, but it is very close now:

next_release...sztamas:next_release

I'll just have to set up a travis on it and then I can publish a version to pypi that supports Django 3.1 and 2.2 LTS.

After that release I will probably spend some more time on do more cleanup and modernise the codebase a bit more as it was quite a bit neglected.

My only concern is that people coming to the project's GitHub page later on won't know that this version is unmaintained and there is a new maintained project, but I don't think there is much we can do about it without someone from Murdoch changing the README on this project.
All we can do is hope that when django-iprestrict won't work they will look at open issues and find these comments...

@ChrisBurch
Copy link
Contributor Author

Thanks @sztamas, much appreciated!

@petedermott
Copy link

@sztamas , great stuff!

I think if you have your fork listed right alongside of this repo in pypi and we have this open issue then people will find it organically and you may be able to wrestle control back from Murdoch eventually. I'm pretty sure similar things have happened with django storages in the past.

Either way, thanks for the hard work on this 👍

@sztamas
Copy link
Contributor

sztamas commented Aug 24, 2020

Hi All,

Django iprestrict redux has been released:

https://github.com/sztamas/django-iprestrict-redux/releases/tag/1.8.1

As I don't have a real Django project I'm using this on, it would be great if you can try it out and let me know how it went.

All you should have to do is install django-iprestrict-redux instead of django-iprestrict from pypi.

Thanks,

Tamas

@ChrisBurch
Copy link
Contributor Author

ChrisBurch commented Aug 24, 2020

This is awesome, thanks for taking the time to give this project some much-deserved love, @sztamas. I just moved our staging stack (django 3.1, python 3.8) from my django3 fork of this project to django-iprestrict-redux, and it's working well.

@sztamas
Copy link
Contributor

sztamas commented Aug 25, 2020

Thanks for trying it out @ChrisBurch !

I also tested it against a demo Django 3.1 app before releasing it so I think we can say now that there are some good chances that it is working :)

I was trying to get it to work for people using Django 3+ ASAP, I will follow up with the less urgent work (switch to it's own read the docs, unforking so issues can be added directly, and more cleanup) next.

@sztamas
Copy link
Contributor

sztamas commented Aug 30, 2020

Hi again,

I've just released 1.9.0 which includes more modernizing and cleanup + fixes the "unknown" issue found by Heroku users. Details:

https://github.com/sztamas/django-iprestrict-redux/blob/master/CHANGELOG.md#190-aug-30-2020

Can you please try this version as well and let me know if it works?
I switched the project to Poetry so the packaging/publishing changed, I hope it still works OK.

I will ask GitHub support to unfork my project as I don't expect muccg to accept any of the changes back in the main repo and I would like to have Issues reported directly on the new repository.

Thanks,

Tamas

@ChrisBurch
Copy link
Contributor Author

Hi Tamas,

I can't speak to the "unknown" issue fix, but pulling in and deploying with 1.9.0 worked just like past versions, so all the Poetry stuff seems to have worked. Good call on unforking the repo -- will be nice to have issues/comms fully on the new repo.

Thanks again for your work on this,
Chris

@sztamas
Copy link
Contributor

sztamas commented Aug 31, 2020

OK, https://github.com/sztamas/django-iprestrict-redux has been unforked now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants