Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to track underlying database without connecting via JS? #1

Open
henrymoulton opened this issue Jan 24, 2022 · 4 comments
Open

Comments

@henrymoulton
Copy link

https://github.com/muchobien/flipper-plugin-react-native-mmkv/blob/main/packages/react-native-mmkv-flipper-plugin/index.ts#L29

My understanding is that it would be better to connect to the MMKV instance directly, perhaps using the Databases approach the Flipper documentation highlights, it might be more performant. https://fbflipper.com/docs/setup/plugins/databases/

@henrymoulton
Copy link
Author

Assume this is why @mrousavy asked https://twitter.com/mrousavy/status/1485336871576215552

but maybe there's another reason.

@KROSF
Copy link
Member

KROSF commented Jan 25, 2022

thanks @henrymoulton, but for now i will add support for several instances and wait for databases to be available for ios

@mrousavy
Copy link

I would actually recommend implementing the Flipper plugin on the JS Side, like @KROSF has already done. That's because the on value changed listeners are set up on the JS Side, and not on native.

So to have the MMKV instance(s) update in realtime in the Flipper Plugin View, we need to listen for value changes.

@KROSF
Copy link
Member

KROSF commented Feb 23, 2022

@henrymoulton now support multiple instances

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants