Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Slower gif animation #71

Closed
sudo-nice opened this Issue Oct 29, 2012 · 6 comments

Comments

Projects
None yet
2 participants
Contributor

sudo-nice commented Oct 29, 2012

sxiv plays some animated gifs slower, than expected. I created some test gifs with imagemagick and noticed, that "-delay" option doesn't affect after some small value. But with other viewers (e.g. pqiv or firefox) the difference is noticeable. I've tried to change the "GIF_DELAY" option in "config.def.h" but without result. Looks like sxiv has a frame per second limit?
Here is an example gif, which plays slower with sxiv: http://ompldr.org/vZzJsMQ

Owner

muennich commented Oct 29, 2012

Fixed by commit 5dbf1b8.

@muennich muennich closed this Oct 29, 2012

Contributor

sudo-nice commented Oct 29, 2012

Thank you, but the commit didn't help to fix the issue. I tried to change the line #150 in "image.c" from:
delay = MAX(delay, MIN_GIF_DELAY);
to:
delay = MIN(delay, MIN_GIF_DELAY);
and got improved gif speed.

P.S. Never mind the solution from above, it made some gifs too fast. I will try something else.

Owner

muennich commented Oct 29, 2012

What exactly is the delay of the gifs, which are not working for you? Is it smaller than 25ms (MIN_GIF_DELAY)?

Contributor

sudo-nice commented Oct 30, 2012

I have a problem with gifs which delay is 50 ms and less. After your last commit, sxiv can play "fast" gifs visually normal after I changeg gif`s delay from 50 ms to 20 ms. But if I open that changed gifs with firefox, they play extremely fast (the same with pqiv). I tried to compile sxiv form source as is to avoid possible effect of my own changes in configuration, but got nothing. Still not sure if it is not my local problem. If you play the gif from my first post with sxiv and a web browser, don't you see the speed difference?
Thank you for your help.

muennich added a commit that referenced this issue Oct 31, 2012

Owner

muennich commented Oct 31, 2012

Does commit 1ae06ff fix this for you?

@muennich muennich reopened this Oct 31, 2012

Contributor

sudo-nice commented Nov 1, 2012

It almost does. I compared the speed with other viewers, and the differences are hardly noticeable. We can close the issue, I think, thank you very much!

@muennich muennich closed this Nov 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment