Skip to content
This repository has been archived by the owner on Jan 16, 2023. It is now read-only.

Slower gif animation #71

Closed
sudo-nice opened this issue Oct 29, 2012 · 6 comments
Closed

Slower gif animation #71

sudo-nice opened this issue Oct 29, 2012 · 6 comments

Comments

@sudo-nice
Copy link
Contributor

sxiv plays some animated gifs slower, than expected. I created some test gifs with imagemagick and noticed, that "-delay" option doesn't affect after some small value. But with other viewers (e.g. pqiv or firefox) the difference is noticeable. I've tried to change the "GIF_DELAY" option in "config.def.h" but without result. Looks like sxiv has a frame per second limit?
Here is an example gif, which plays slower with sxiv: http://ompldr.org/vZzJsMQ

@xyb3rt
Copy link
Owner

xyb3rt commented Oct 29, 2012

Fixed by commit 5dbf1b8.

@xyb3rt xyb3rt closed this as completed Oct 29, 2012
@sudo-nice
Copy link
Contributor Author

Thank you, but the commit didn't help to fix the issue. I tried to change the line #150 in "image.c" from:
delay = MAX(delay, MIN_GIF_DELAY);
to:
delay = MIN(delay, MIN_GIF_DELAY);
and got improved gif speed.

P.S. Never mind the solution from above, it made some gifs too fast. I will try something else.

@xyb3rt
Copy link
Owner

xyb3rt commented Oct 29, 2012

What exactly is the delay of the gifs, which are not working for you? Is it smaller than 25ms (MIN_GIF_DELAY)?

@sudo-nice
Copy link
Contributor Author

I have a problem with gifs which delay is 50 ms and less. After your last commit, sxiv can play "fast" gifs visually normal after I changeg gif`s delay from 50 ms to 20 ms. But if I open that changed gifs with firefox, they play extremely fast (the same with pqiv). I tried to compile sxiv form source as is to avoid possible effect of my own changes in configuration, but got nothing. Still not sure if it is not my local problem. If you play the gif from my first post with sxiv and a web browser, don't you see the speed difference?
Thank you for your help.

xyb3rt added a commit that referenced this issue Oct 31, 2012
@xyb3rt
Copy link
Owner

xyb3rt commented Oct 31, 2012

Does commit 1ae06ff fix this for you?

@xyb3rt xyb3rt reopened this Oct 31, 2012
@sudo-nice
Copy link
Contributor Author

It almost does. I compared the speed with other viewers, and the differences are hardly noticeable. We can close the issue, I think, thank you very much!

@xyb3rt xyb3rt closed this as completed Nov 1, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants