Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: formatting of short flags when PFlag=true #8

Merged
merged 1 commit into from Feb 5, 2022
Merged

fix: formatting of short flags when PFlag=true #8

merged 1 commit into from Feb 5, 2022

Conversation

alecthomas
Copy link
Contributor

Previously this was formatted as eg.

--h --help

Now it will be:

-h, --help

@alecthomas
fix: formatting of short flags
38e8d8b 
Previously this was formatted as eg.

    --h --help

Now it will be:

    -h, --help
@alecthomas
Copy link
Contributor Author

I also added the comma because that seems to be more idiomatic, eg. man git, man brew, etc. all use this format.

@alecthomas
Copy link
Contributor Author

Related, I created a mango adapter for Kong.

@muesli muesli added the bug Something isn't working label Feb 5, 2022
@muesli
Copy link
Owner

muesli commented Feb 5, 2022

Awesome, great job on this, kong and the mango adapter, @alecthomas! We should add it to mango's README!

@muesli muesli merged commit 77e2058 into muesli:main Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alecthomas @muesli