Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the ASCII art to a separate file #10

Closed
AMythicDev opened this issue Oct 3, 2020 · 5 comments · Fixed by #11
Closed

Move the ASCII art to a separate file #10

AMythicDev opened this issue Oct 3, 2020 · 5 comments · Fixed by #11
Labels
enhancement New feature or request
Milestone

Comments

@AMythicDev
Copy link
Contributor

AMythicDev commented Oct 3, 2020

I was inspecting your sources, The ASCII art didn't looked good in the middle of the source code. It would be better if you move it to a separate file or maybe make it a const. Also the line that tells about the host and port could be put along with the ASCII art. You should use the include_str! macro to include it into the source code during compilation and use it in the println! also specifying the host and port

@mufeedvh mufeedvh added the enhancement New feature or request label Oct 3, 2020
@mufeedvh
Copy link
Owner

mufeedvh commented Oct 3, 2020

Hey @arijit79, thanks for raising this issue! This is indeed a good way to do, I will make a banner file that gets printed out with include_str! during execution. It does seem messy inside the code, I will definitely push this change soon! ❤️🙌

@AMythicDev
Copy link
Contributor Author

Also, unrelated to this issue, but something related to formatting is that your files in the static folder are all in one line, you should probably format them according HTML writing styles. If you use an IDE like VSCode or Atom, they have plugins to improve the formatting of HTML

@mufeedvh
Copy link
Owner

mufeedvh commented Oct 3, 2020

I just made it one-liners because it's default generated templates and short in LOC. But yes it would improve readability in format, thank you for the request, I will definitely look into this as well. 😃👍

@AMythicDev
Copy link
Contributor Author

I will filing a PR to fix the HTML issue

@mufeedvh
Copy link
Owner

mufeedvh commented Oct 3, 2020

Awesome @arijit79, thank you! ❤️🙌

@mufeedvh mufeedvh added this to the v0.2.0 milestone Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants